Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE: fix issues with vector/vector binary comparsion operations #10235

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Dec 13, 2024

What this PR does

This PR fixes two issues with the implementation of comparison operations between two vectors without the bool modifier in MQE:

  • Queries would return incorrect results if the left side contained series with different metric names, and all results would be merged into a single series rather than returned in separate series for each metric name
  • Queries would incorrectly fail with a conflict error if multiple series on the left side matched the same series on the right side, those left side series had points at the same timestamp, and one or none of those points remained after applying the comparison operation

This PR is a draft pending benchmarking and profiling of the impact of these changes.

Which issue(s) this PR fixes or relates to

#10067

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [covered by Mimir Query Engine #10067] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

… return incorrect results if the left side contained series with different metric names
… fail with a conflict if multiple left series match the same right series and only one left point remains after applying the comparison
@charleskorn charleskorn force-pushed the charleskorn/mqe-comparison-binop-fixes branch from d8b53a1 to 73b9e18 Compare January 8, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant